zjffdu commented on a change in pull request #7455: [FLINK-11288][build]
Exclude flink-ml from flink-dist
URL: https://github.com/apache/flink/pull/7455#discussion_r248273048
##########
File path: flink-dist/src/main/assemblies/opt.xml
##########
@@ -75,14 +75,6 @@
<fileMode>0644</fileMode>
</file>
- <!-- ML -->
- <file>
-
<source>../flink-libraries/flink-ml/target/flink-ml_${scala.binary.version}-${project.version}-jar-with-dependencies.jar</source>
- <outputDirectory>opt/</outputDirectory>
-
<destName>flink-ml_${scala.binary.version}-${project.version}.jar</destName>
- <fileMode>0644</fileMode>
- </file>
-
Review comment:
Why would it not a part of the binary distribution ? What if user want to
try ml in scala-shell or user want to run ml examples via bin/flink ?
(currently there's no ml example in flink-examples, but I think we should add
that in future)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
