TisonKun commented on a change in pull request #7512: [FLINK-11294][tests]
Remove legacy JobInfo usage in valid tests
URL: https://github.com/apache/flink/pull/7512#discussion_r248354857
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/ZooKeeperSubmittedJobGraphsStoreITCase.java
##########
@@ -114,7 +112,7 @@ public void testPutAndRemoveJobGraph() throws Exception {
verifyJobGraphs(jobGraph,
jobGraphs.recoverJobGraph(jobId));
// Update (same ID)
- jobGraph = createSubmittedJobGraph(jobGraph.getJobId(),
1);
+ jobGraph = createSubmittedJobGraph(jobGraph.getJobId());
jobGraphs.putJobGraph(jobGraph);
// Verify updated
Review comment:
`verifyJobGraphs` verifies JobID and JobName, if we don't change both of
them, we should remove such verification. Otherwise we' better to check update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
