aljoscha commented on a change in pull request #7493: [FLINK-11036] Fix
test_streaming_classloader.sh end-to-end test
URL: https://github.com/apache/flink/pull/7493#discussion_r248632277
##########
File path:
flink-end-to-end-tests/flink-parent-child-classloading-test-program/src/main/java/org/apache/flink/streaming/tests/ClassLoaderTestProgram.java
##########
@@ -52,48 +48,28 @@ public static void main(String[] args) throws Exception {
String gitCommitId;
- try (InputStream propFile =
ClassLoaderTestProgram.class.getClassLoader().getResourceAsStream(".version.properties"))
{
+ try (InputStream propFile =
ClassLoaderTestProgram.class.getClassLoader().getResourceAsStream("parent-child-test.properties"))
{
Review comment:
We could do that, but we would basically test that the context classloader
is being set correctly. I think we already cover that in unit tests.
Also, I want to keep this change to only fix what we currently have. 😅
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
