azagrebin commented on a change in pull request #7526: [FLINK-11353][tests]
Port JobManagerHAJobGraphRecoveryITCase to new code base
URL: https://github.com/apache/flink/pull/7526#discussion_r249100240
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherHATest.java
##########
@@ -150,8 +154,22 @@ public void testGrantingRevokingLeadership() throws
Exception {
}
@Nonnull
- private HATestingDispatcher
createHADispatcher(TestingHighAvailabilityServices highAvailabilityServices,
BlockingQueue<DispatcherId> fencingTokens) throws Exception {
+ private HATestingDispatcher
createDispatcher(TestingHighAvailabilityServices highAvailabilityServices,
Queue<DispatcherId> fencingTokens) throws Exception {
Review comment:
I would suggest to group all helper methods after tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
