[
https://issues.apache.org/jira/browse/FLINK-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14713019#comment-14713019
]
ASF GitHub Bot commented on FLINK-2512:
---------------------------------------
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1058#issuecomment-134980990
I don't get it. You are not instantiating a CopyOnWriteArrayList here, but
just cast the list returned by the runtime context. Either this works and the
returned list is already a CopyOnWriteArrayList, in which case this does
nothing. Or it's not a CopyOnWriteArrayList and the cast fails at runtime.
What are you trying to fix here? In general, fixes should come with a test
to verify them as well. Otherwise, it's too easy to loose fixes and very hard
to understand what is being fixed when reviewing.
> Add client.close() before throw RuntimeException
> ------------------------------------------------
>
> Key: FLINK-2512
> URL: https://issues.apache.org/jira/browse/FLINK-2512
> Project: Flink
> Issue Type: Bug
> Components: flink-contrib
> Affects Versions: 0.8.1
> Reporter: fangfengbin
> Assignee: fangfengbin
> Priority: Minor
> Fix For: 0.10
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
