Github user uce commented on the pull request:

    https://github.com/apache/flink/pull/1058#issuecomment-134980990
  
    I don't get it. You are not instantiating a CopyOnWriteArrayList here, but 
just cast the list returned by the runtime context. Either this works and the 
returned list is already a CopyOnWriteArrayList, in which case this does 
nothing. Or it's not a CopyOnWriteArrayList and the cast fails at runtime.
    
    What are you trying to fix here? In general, fixes should come with a test 
to verify them as well. Otherwise, it's too easy to loose fixes and very hard 
to understand what is being fixed when reviewing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to