azagrebin commented on a change in pull request #7351: [FLINK-11008][State
Backends, Checkpointing]SpeedUp upload state files using multithread
URL: https://github.com/apache/flink/pull/7351#discussion_r250317750
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/AsyncSnapshotCallable.java
##########
@@ -97,6 +97,10 @@ protected void cancel() {
}
}
+ protected CloseableRegistry getSnapshotCloseableRegistry() {
+ return snapshotCloseableRegistry;
Review comment:
could we just make `snapshotCloseableRegistry` protected and use it directly
in `RocksIncrementalSnapshotStrategy`? I think we do not need
`(un)registerCloseableForCancellation` methods either afterwards and replace
calls to them with direct calls to
`snapshotCloseableRegistry.(un)registerCloseable`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
