zentol commented on a change in pull request #7539: [FLINK-11354][tests] Port
JobManagerHARecoveryTest to new code base
URL: https://github.com/apache/flink/pull/7539#discussion_r250599168
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobManagerRunnerTest.java
##########
@@ -208,13 +200,19 @@ public void testShutDown() throws Exception {
@Test
public void testLibraryCacheManagerRegistration() throws Exception {
- final JobManagerRunner jobManagerRunner =
createJobManagerRunner();
+ final BlobLibraryCacheManager libraryCacheManager = new
BlobLibraryCacheManager(
+ VoidPermanentBlobService.INSTANCE,
+ FlinkUserCodeClassLoaders.ResolveOrder.CHILD_FIRST,
+ new String[]{});
+ final JobManagerSharedServices jobManagerSharedServices = new
TestingJobManagerSharedServicesBuilder()
+ .setLibraryCacheManager(
+ libraryCacheManager)
Review comment:
can be on the same line as `setLibraryCacheManager`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services