yanghua commented on a change in pull request #7571: [FLINK-10724] Refactor
failure handling in check point coordinator
URL: https://github.com/apache/flink/pull/7571#discussion_r250852230
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinatorTest.java
##########
@@ -1553,6 +1697,95 @@ public void testTriggerAndConfirmSimpleSavepoint()
throws Exception {
coord.shutdown(JobStatus.FINISHED);
}
+ @Test
+ public void testTriggerAndDeclineSimpleSavepointWithExecutionFailure()
throws Exception {
Review comment:
According to the current implementation, savepoint will definitely not
trigger the job to fail. Because savepoint is always forced (it will throw an
exception and terminate subsequent execution). So this needs to be discussed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
