stevenzwu commented on issue #7020: [FLINK-10774] [Kafka] connection leak when 
partition discovery is disabled an…
URL: https://github.com/apache/flink/pull/7020#issuecomment-457804477
 
 
   @tillrohrmann I like the refactoring. better code structure. 
   
   But it doesn't solve the original problem. if this line (from your repo) 
throws an exception, resource is not closed. 
   473          final List<KafkaTopicPartition> allPartitions = 
partitionDiscoverer.discoverPartitions();

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to