[
https://issues.apache.org/jira/browse/FLINK-11316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary Yao closed FLINK-11316.
----------------------------
Resolution: Fixed
fixed via
6c01cf92b6050b66e5bf1ea9057266c9edaedff4
3fdb2af0ff51420becf99ece15fb02b96bc02f6a
> JarFileCreatorTest fails when run with Java 9
> ---------------------------------------------
>
> Key: FLINK-11316
> URL: https://issues.apache.org/jira/browse/FLINK-11316
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
> Affects Versions: 1.8.0
> Reporter: Gary Yao
> Assignee: TisonKun
> Priority: Major
> Labels: pull-request-available, tests
> Fix For: 1.8.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> *Description*
> {{JarFileCreatorTest}} fails when run with Java 9. Because {{JarFileCreator}}
> is not used in production, the class and its tests can be deleted.
> Stacktrace:
> {code}
> java.lang.IllegalArgumentException
> at
> org.apache.flink.shaded.asm5.org.objectweb.asm.ClassReader.<init>(Unknown
> Source)
> at
> org.apache.flink.shaded.asm5.org.objectweb.asm.ClassReader.<init>(Unknown
> Source)
> at
> org.apache.flink.shaded.asm5.org.objectweb.asm.ClassReader.<init>(Unknown
> Source)
> at
> org.apache.flink.runtime.util.JarFileCreator.addDependencies(JarFileCreator.java:146)
> at
> org.apache.flink.runtime.util.JarFileCreator.createJarFile(JarFileCreator.java:178)
> at
> org.apache.flink.runtime.util.JarFileCreatorTest.TestAnonymousInnerClassTrick1(JarFileCreatorTest.java:57)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:564)
> {code}
> *Steps to reproduce*
> With the Java 9 compiler in the path, run:
> {code}
> mvn test -Pjava9 -DfailIfNoTests=false -Dfast
> -Dtest=org.apache.flink.runtime.util.JarFileCreatorTest
> {code}
> Alternatively, run the test from IntelliJ with the {{java9}} profile enabled.
> *Acceptance Criteria*
> * {{JarFileCreator}} and {{JarFileCreatorTest}} are deleted
> * Usage of {{JarFileCreator}} in
> {{ClassLoaderUtilsTest#testWithURLClassLoader}} is replaced with an
> alternative
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
