tillrohrmann commented on a change in pull request #7563: [FLINK-11414]
Introduce JobMasterService interface
URL: https://github.com/apache/flink/pull/7563#discussion_r251441238
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
##########
@@ -313,31 +314,29 @@ public void start() {
* Start the rpc service and begin to run the job.
*
* @param newJobMasterId The necessary fencing token to run the job
- * @param timeout for the operation
* @return Future acknowledge if the job could be started. Otherwise
the future contains an exception
*/
- public CompletableFuture<Acknowledge> start(final JobMasterId
newJobMasterId, final Time timeout) throws Exception {
+ public CompletableFuture<Acknowledge> start(final JobMasterId
newJobMasterId) throws Exception {
// make sure we receive RPC and async calls
super.start();
- return callAsyncWithoutFencing(() ->
startJobExecution(newJobMasterId), timeout);
+ return callAsyncWithoutFencing(() ->
startJobExecution(newJobMasterId), RpcUtils.INF_TIMEOUT);
Review comment:
Yes, `start` is not really a true RPC call because you can only call it
locally. What you want is that this happens and there should not be a timeout
when it takes longer than the specified `timeout` value. Moreover, you can
always block with a timeout specified on the returned future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
