tillrohrmann commented on issue #7564: [FLINK-11415] Introduce JobMasterServiceFactory URL: https://github.com/apache/flink/pull/7564#issuecomment-458167703 Thanks for the review @azagrebin. Concerning your points: - I would like to not move the user code class loader generation into the factory because it's the `JobManagerRunner's` task to manage the lifecycle of the user code class loader. This would need to be duplicated for every `JobMasterServiceFactory` implementation. Moreover, in the future I would like to change the `JobManagerRunner` so that it only creates a `JobMasterRunner` if it has gained the leadership. - I guess the `JobMaster` construction process could be stream lined as well. However, I would see this as an orthogonal topic which could be done as a follow up. - The `JobMasterServiceFactory` will be used in #7565 for testing the `JobManagerRunner`. That's also the reason why I introduced it. - Not sure whether I got your last point. Could you try to rephrase it? Do you mean the `JobMasterServiceFactory` can be subsumed by the `JobManagerRunnerFactory`? Or do you mean the opposite (getting rid of `JobManagerRunnerFactory`)? I think at the moment we also use the `JobManagerRunnerFactory` abstraction in some tests. Therefore I'm not 100% sure whether this is possible. - Parameterizing the `DefaultJobManagerRunnerFactory` with the `JobMasterServiceFactory` can be done when the need for it is there.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
