lamber-ken commented on issue #7571: [FLINK-10724] Refactor failure handling in check point coordinator URL: https://github.com/apache/flink/pull/7571#issuecomment-458223164 > @lamber-ken answer your questions: > > * yes, now when checkpoint failure we just send a decline message to `CheckpointCoordinator` and let it consider whether fail the job or not. > > * I think there is not necessary to add a default statement, because `TaskAcknowledgeResult` is the type of the enum. It just defines four enum values which all been contained in the switch block. We can't guarantee that the `TaskAcknowledgeResult` value will never expand. If add a new enum in the futher and forget to add a switch branch, it'll make some unknown error, it's better to add a default statement, for example `throw RuntimeException("unknown type")`, this will remind us.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
