[ 
https://issues.apache.org/jira/browse/FLINK-11352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16754685#comment-16754685
 ] 

Congxian Qiu edited comment on FLINK-11352 at 1/29/19 9:40 AM:
---------------------------------------------------------------

Hi [~till.rohrmann] Update for {{testCheckpointRecoveryFailure}}.

I dug a bit more and found there exist a test class called 
{{JobManagerHAProcessFailureRecoveryITCase}}, I think we can implement  
{{JobManagerHACheckpointRecoveryITCase::testCheckpointRecoveryFailure}} in 
there, the logic will similar with the 
{{JobManagerHAProcessFailureRecoveryITCase::testDispatcherProcessFailure}}, but 
we should remove the directory {{coordinateTempDir}} before starting the second 
dispatcher and verify that the except error log printed after the second 
dispatcher process started.

[gist link|https://gist.github.com/klion26/eafa6174df361d3bb0447c2e7681db0f] of 
the new code.

What do you think about this? If this is ok, I'll implement.


was (Author: klion26):
Hi [~till.rohrmann] Update for {{testCheckpointRecoveryFailure}}.

I dug a bit more and found there exist a test class called 
{{JobManagerHAProcessFailureRecoveryITCase}}, I think we can implement  
{{JobManagerHACheckpointRecoveryITCase::testCheckpointRecoveryFailure}} in 
there, the logic will similar with the 
{{JobManagerHAProcessFailureRecoveryITCase::testDispatcherProcessFailure}}, but 
we should remove the directory {{coordinateTempDir}} before starting the second 
dispatcher and verify that the except error log printed after the second 
dispatcher process started.

What do you think about this? If this is ok, I'll implement.

> Check and port JobManagerHACheckpointRecoveryITCase to new code base if 
> necessary
> ---------------------------------------------------------------------------------
>
>                 Key: FLINK-11352
>                 URL: https://issues.apache.org/jira/browse/FLINK-11352
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Tests
>            Reporter: Till Rohrmann
>            Assignee: Congxian Qiu
>            Priority: Major
>
> Check and port {{JobManagerHACheckpointRecoveryITCase}} to new code base if 
> necessary



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to