tzulitai commented on issue #7590: [FLINK-11329][core] Migrating 
CompositeSerializers
URL: https://github.com/apache/flink/pull/7590#issuecomment-458882745
 
 
   Thanks for the work @igalshilman!
   
   For every serializer that is touched, I checked that:
   - The touched serializer has a `serialVersionUID` defined already so that 
we're not breaking backwards compatibility
   - The `ensureCompatibility` method is removed (except from 
`CompositeSerializer`)
   - Old config snapshot correctly delegates compatibility check to new 
serializer
   - Has migration tests that cover the change
   
   LGTM. I'll merge 
https://github.com/tzulitai/flink/tree/igal-dawid-gordon-composite once Travis 
is green!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to