aljoscha commented on a change in pull request #7601: [FLINK-11164] Check for
sentinel values when creating new Kinesis ShardIterator
URL: https://github.com/apache/flink/pull/7601#discussion_r252240790
##########
File path:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
##########
@@ -380,7 +381,19 @@ private GetRecordsResult getRecords(String shardItr, int
maxNumberOfRecords) thr
} catch (ExpiredIteratorException eiEx) {
LOG.warn("Encountered an unexpected expired
iterator {} for shard {};" +
" refreshing the iterator ...",
shardItr, subscribedShard);
- shardItr =
kinesis.getShardIterator(subscribedShard,
ShardIteratorType.AFTER_SEQUENCE_NUMBER.toString(),
lastSequenceNum.getSequenceNumber());
+ if
(SentinelSequenceNumber.getAllSentinelSequenceNumbers().contains(lastSequenceNum))
{
+ // we cannot create a shard iterator
because we still have an initial sentinel
+ // value as the current sequence number
+ LOG.warn(
Review comment:
Could we just call `getInitialShardIterator()`? If not, I'll probably factor
out the if-branches that deal with sentinel values into a new method. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
