tillrohrmann commented on a change in pull request #7568: [FLINK-11417] Make
access to ExecutionGraph single threaded from JobMaster main thread
URL: https://github.com/apache/flink/pull/7568#discussion_r252273578
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionVertexCancelTest.java
##########
@@ -169,7 +169,7 @@ public void
testCancelConcurrentlyToDeploying_CallsNotOvertaking() {
assertEquals(ExecutionState.CANCELED,
vertex.getExecutionState());
// trigger the correction canceling call
- actions.triggerNextAction();
+// actions.triggerNextAction();
Review comment:
I think this test case is no longer valid since the `Execution#deploy` call
no longer checks whether it is still in state `DEPLOYING` after it has
completed. If I remember correctly, this test originates from the time when
there was no order guarantee of the sent messages to the `TaskExecutor`. Thus,
we can remove it completely.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
