tillrohrmann opened a new pull request #7606: [FLINK-10774] Rework lifecycle management of partitionDiscoverer in FlinkKafkaConsumerBase URL: https://github.com/apache/flink/pull/7606 ## What is the purpose of the change This PR reworks the lifecycle management of the `FlinkKafkaConsumerBase#partitionDiscoverer` such that it will always be closed in the `close()` method. This implies that all users of this class need to call `close()` in order to properly clean up resources. cc @stevenzwu @tzulitai ## Brief change log - Remove closing of `partitionDiscoverer` from `#run` method - separate `FlinkKafkaConsumerBase#cancel` and `#close` such that cancel is non blocking and `close` will release all required resources ## Verifying this change - Added tests: `FlinkKafkaConsumerBaseTest#testClosePartitionDiscovererWhenOpenThrowException`, `#testClosePartitionDiscovererWhenCreateKafkaFetcherFails`, `#testClosePartitionDiscovererWhenKafkaFetcherFails` and `#testClosePartitionDiscovererWithCancellation` ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
