tillrohrmann commented on a change in pull request #7356:
[FLINK-10868][flink-yarn] Enforce maximum TMs failure rate in ResourceManagers
URL: https://github.com/apache/flink/pull/7356#discussion_r252360809
##########
File path:
flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerTest.java
##########
@@ -521,4 +533,56 @@ public void testOnContainerCompleted() throws Exception {
});
}};
}
+
+ /**
+ * Tests that YarnResourceManager will trigger to reject all
pending slot request, when maximum number of failed
+ * contains is hit.
+ */
+ @Test
+ public void testOnContainersAllocatedWithFailure() throws Exception {
Review comment:
With the generalized test for the failure rate behaviour in
`ResourceManagerTest` we would only need to check that a failing container
would call `ResourceManager#recordFailure`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
