[
https://issues.apache.org/jira/browse/FLINK-11449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757410#comment-16757410
]
Dawid Wysakowicz edited comment on FLINK-11449 at 1/31/19 4:05 PM:
-------------------------------------------------------------------
In general I like the proposal from [~twalthr], this indeed would allow us in
the future to unify handling of built-in functions and UDFs.
I have just two comments:
* do we need the {{ValueLiteralExpression(Object, TypeInformation)}}? I think
we could express it with {{CallExpression(CAST,
ValueLiteralExpression(Object))}} which would be in line with SQL.
* don't we need {{UserDefinedAggFunctionDefinition}} and
{{UserDefinedTableFunctionDefinition}} to pass through the {{TypeInformation}}
(resultTypeInfo, accTypeInfo) that was derived during function registration?
was (Author: dawidwys):
In general I like the proposal from [~twalthr], this indeed would allow us in
the future to unify handling of built-in functions and UDFs.
I have just two comments:
* do we need the {{ValueLiteralExpression(Object, TypeInformation)}}? I think
we could express it with {{CallExpression(CAST,
ValueLiteralExpression(Object))}} which would be in line with SQL.
* don't we need to pass {{UserDefinedAggFunctionDefinition}} and
{{UserDefinedTableFunctionDefinition}} to pass through the {{TypeInformation}}
(resultTypeInfo, accTypeInfo) that was derived during function registration?
> Uncouple the Expression class from RexNodes
> -------------------------------------------
>
> Key: FLINK-11449
> URL: https://issues.apache.org/jira/browse/FLINK-11449
> Project: Flink
> Issue Type: New Feature
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: sunjincheng
> Priority: Major
>
> A more detailed description can be found in
> [FLIP-32|https://cwiki.apache.org/confluence/display/FLINK/FLIP-32%3A+Restructure+flink-table+for+future+contributions].
> Calcite will not be part of any API module anymore. Therefore, RexNode
> translation must happen in a different layer. This issue will require a new
> design document.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
