dawidwys commented on issue #7626: [FLINK-11450][table] Port and move TableSource and TableSink to flink-table-common URL: https://github.com/apache/flink/pull/7626#issuecomment-459655863 Hi @dianfu , I have few comments before starting to review the PR: - I appreciate your work, but it would be better if you could keep the scope as it was originally planned in the corresponding JIRA? This PR actually covers multiple different JIRAs: [FLINK-10755](https://issues.apache.org/jira/browse/FLINK-10755), [FLINK-11451](https://issues.apache.org/jira/browse/FLINK-11451) and probably few more - Could you please split PRs into smaller chunks(commits) that make sense on their own. It simplifies reviewing enormously. Right now it is nearly impossible to review 4k changed lines at once. This somewhat relates to the previous point, as the JIRAs try to split the rework into those individual subtasks.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
