tillrohrmann commented on a change in pull request #7647:
[FLINK-11352][tests]Port JobManagerHACheckpointRecoveryITCase to new code base
URL: https://github.com/apache/flink/pull/7647#discussion_r253532313
##########
File path:
flink-tests/src/test/java/org/apache/flink/test/recovery/JobManagerHAProcessFailureRecoveryITCase.java
##########
@@ -220,6 +221,187 @@ public void flatMap(Long value, Collector<Long> out)
throws Exception {
env.execute();
}
+ /**
+ * Tests that the JobManager logs failures during recovery properly.
+ *
+ * @see <a
href="https://issues.apache.org/jira/browse/FLINK-3185";>FLINK-3185</a>
+ */
+ @Test
+ public void testJobManagerRecoveryFailureLog() throws Exception {
Review comment:
I think it would be better to test the behaviour more fine grained. What we
actually tested was that the recovery logs a message if there is a recovery
failure due to non-existing state handles. However, the behaviour slightly
changed such that a failing recovery will lead to a `Dispatcher` termination
(see `DispatcherHATest#testFailingRecoveryIsAFatalError`). Thus, I think this
test is no longer necessary and can be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
