azagrebin commented on a change in pull request #7163: [FLINK-10471][State TTL]
State TTL cleanup using RocksDb compaction filter
URL: https://github.com/apache/flink/pull/7163#discussion_r253921150
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
##########
@@ -428,15 +434,26 @@ public void dispose() {
// invalidate the reference
db = null;
- IOUtils.closeQuietly(columnOptions);
IOUtils.closeQuietly(dbOptions);
IOUtils.closeQuietly(writeOptions);
+
+
ttlCompactFiltersManager.disposeAndClearRegisteredCompactionFactories();
Review comment:
`RocksDbKvStateInfo` could contain `FlinkCompactionFilterFactory`, I just
changed it with the last commit. I wanted to keep filter specifics outside of
the backend code.
About closing order (also your previous comment about closing factories), as
I understand, everything should be closed in the reversed order of creating,
right? So even column options should actually be closed after db as it was
before. Factories have to be closed also after db and probably better after
options.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
