Github user mjsax commented on a diff in the pull request:

    https://github.com/apache/flink/pull/750#discussion_r37996420
  
    --- Diff: 
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/test/java/org/apache/flink/stormcompatibility/api/FlinkTestCluster.java
 ---
    @@ -25,15 +25,21 @@
     import backtype.storm.generated.StormTopology;
     import backtype.storm.generated.SubmitOptions;
     import backtype.storm.generated.TopologyInfo;
    +
    +import org.apache.flink.api.common.JobID;
    +import org.apache.flink.runtime.jobgraph.JobGraph;
     import 
org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
     import org.apache.flink.streaming.util.TestStreamEnvironment;
     
    +import java.util.HashMap;
     import java.util.Map;
     
     /**
      * {@link FlinkTestCluster} mimics a Storm {@link LocalCluster} for 
ITCases via a {@link TestStreamEnvironment}.
      */
     public class FlinkTestCluster extends FlinkLocalCluster {
    +   // TODO remove and look up job
    --- End diff --
    
    This is also a larger issue in Storm compatibility (and not related to this 
PR). Need to add helper method to `ClusterUtil` to get running jobs from 
`LocalFlinkMiniCluster` which is used under the hood. I would rather have 
another JIRA for this than including it here. Effects `FlinkLocalCluster`, too. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to