zentol commented on a change in pull request #7659: [FLINK-11514][client] Port
ClusterClientTest
URL: https://github.com/apache/flink/pull/7659#discussion_r254669226
##########
File path:
flink-clients/src/test/java/org/apache/flink/client/program/rest/RestClusterClientTest.java
##########
@@ -448,20 +457,24 @@ public void testTriggerSavepoint() throws Exception {
try {
JobID id = new JobID();
{
- CompletableFuture<String>
savepointPathFuture = restClusterClient.triggerSavepoint(id, null);
- String savepointPath =
savepointPathFuture.get();
+ String savepointPath = cancelJob
Review comment:
I agree that the test is overloaded, but don't think this flag makes this
significantly worse. I would be up for refactoring the test into 4-5 separate
ones in a follow-up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
