GJL commented on a change in pull request #7659: [FLINK-11514][client] Port
ClusterClientTest
URL: https://github.com/apache/flink/pull/7659#discussion_r254670295
##########
File path:
flink-clients/src/test/java/org/apache/flink/client/program/rest/RestClusterClientTest.java
##########
@@ -448,20 +457,24 @@ public void testTriggerSavepoint() throws Exception {
try {
JobID id = new JobID();
{
- CompletableFuture<String>
savepointPathFuture = restClusterClient.triggerSavepoint(id, null);
- String savepointPath =
savepointPathFuture.get();
+ String savepointPath = cancelJob
Review comment:
I meant that a single test for testing that the flag can be set to `true`
would be enough. For the `false` case all scenarios in `testTriggerSavepoint`
should be kept. It is not always feasible to test all combinations anyways.
Hence, it would be enough to pick one representative test case for _cancel with
savepoint_.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
