GJL commented on a change in pull request #7661: [FLINK-11515][client] Port
ClientTest
URL: https://github.com/apache/flink/pull/7661#discussion_r254673467
##########
File path:
flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java
##########
@@ -216,41 +177,13 @@ public void shouldSubmitToJobClient() throws Exception {
program.deleteExtractedLibraries();
}
- /**
- * This test verifies correct that the correct exception is thrown when
the job submission fails.
- */
- @Test
- public void shouldSubmitToJobClientFails() throws Exception {
- jobManagerSystem.actorOf(
- Props.create(FailureReturningActor.class),
- JobMaster.JOB_MANAGER_NAME);
-
- StandaloneClusterClient out = new
StandaloneClusterClient(config);
- out.setDetached(true);
-
- try {
- out.run(program.getPlanWithJars(), 1);
- fail("This should fail with an exception");
- }
- catch (ProgramInvocationException e) {
- // bam!
- }
- catch (Exception e) {
- fail("wrong exception " + e);
- }
- }
-
/**
* This test verifies that the local execution environment cannot be
created when
* the program is submitted through a client.
*/
@Test
public void tryLocalExecution() {
try {
Review comment:
Maybe delete the
```
catch (Exception e) {
e.printStackTrace();
fail(e.getMessage());
}
```
block here as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
