StefanRRichter edited a comment on issue #7586: [FLINK-10912][rocksdb] Configurable RocksDBStateBackend options URL: https://github.com/apache/flink/pull/7586#issuecomment-461428217 @Myasuka Thanks a lot for this contribution. Before starting the review, I first have a few high level questions. When reading the corresponding JIRA issue, the issue was mainly about making the `OptionsFactory` configurable in the flink-configuration. In contrast to that, this PR does not make `OptionsFactory` configurable, but instead exposes some partibular RocksDB specific options, e.g. compaction style. While this approach might be more comfortable for users, it is also less flexible/powerful than the approach described in the JIRA. So what that in mind I wonder if we could not do the following: - make the `OptionsFactory` configurable in the configuration. - provide a default implementation of `OptionsFactory` that is based on (or using) the functionality that you currently have in `RocksDBCustomizedOptions` und can also be extended by the user. That means, this default factory will react to the setting defined in this PR. With this, i) the user can easily configure particular options (like compaction) as with your current PR, but ii) they can also completely override the `OptionsFactory` in the flink config, e.g. because they need another option that we do not cover, and iii) they can extend the easy & flexible by extending the default factory. The default factory without anything configured will just use predifined options and keep them untouched. What do you think?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
