igalshilman commented on a change in pull request #7658: [FLINK-10493][core]
Migrating the TupleSerializerBase serializers family
URL: https://github.com/apache/flink/pull/7658#discussion_r254708093
##########
File path:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeTypeSerializerSnapshot.java
##########
@@ -155,7 +155,7 @@ public final void readSnapshot(int readVersion,
DataInputView in, ClassLoader us
TypeSerializerSchemaCompatibility<T> internalResolveSchemaCompatibility(
TypeSerializer<T> newSerializer,
TypeSerializerSnapshot<?>[] snapshots) {
- if (newSerializer.getClass() != correspondingSerializerClass) {
+ if (!correspondingSerializerClass.isInstance(newSerializer)) {
Review comment:
It is here because some of the tuple serializers snapshot are using an
instance of `SpecificCaseClassSerializer` (i.e.
`Tuple2CaseClassSerializerSnapshot`) during the migration path from pre 1.8
(where previously all the tuple related serializers used the same
`TypeSerializerConfigSnapshot`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
