pnowojski commented on a change in pull request #6787: [FLINK-8577][table]
Implement proctime DataStream to Table upsert conversion
URL: https://github.com/apache/flink/pull/6787#discussion_r254982253
##########
File path:
flink-examples/flink-examples-table/src/main/scala/org/apache/flink/table/examples/scala/StreamTableExample.scala
##########
@@ -44,12 +44,12 @@ object StreamTableExample {
val orderA = env.fromCollection(Seq(
Review comment:
nit: 2nd commit
> [FLINK-8577][table] Rename methods name to toTableFromAppendStream and
toTableFromUpsertStream in DataStreamConversions
has no code changes related to `toTableFromUpsertStream`. Probably commit
should be renamed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
