yanghua commented on a change in pull request #7263: [FLINK-11081] Support
binding port range for REST server
URL: https://github.com/apache/flink/pull/7263#discussion_r255060193
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/RestOptions.java
##########
@@ -37,6 +37,18 @@
.withDeprecatedKeys(WebOptions.ADDRESS.key(),
ConfigConstants.DEFAULT_JOB_MANAGER_WEB_FRONTEND_ADDRESS.key())
.withDescription("The address that the server binds
itself.");
+ /**
+ * The port range that the server could bind itself to.
+ */
+ public static final ConfigOption<String> BIND_PORT =
+ key("rest.bind-port")
+ .defaultValue("8081")
+ .withDeprecatedKeys("rest.port", WebOptions.PORT.key(),
ConfigConstants.JOB_MANAGER_WEB_PORT_KEY)
Review comment:
@zentol thanks for your suggestion. I have defined a private static filed
named `REST_PORT_KEY` in `RestOptions` class, because I think this key is just
referenced for REST service, so I do not define it `ConfigConstants` and it
seems `ConfigConstants` is the legacy class. If you think `ConfigConstants` is
a better choice, I also would like to change this field's location.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
