alexeyt820 commented on a change in pull request #6615: [FLINK-8354] 
[flink-connectors] Add ability to access and provider Kafka headers
URL: https://github.com/apache/flink/pull/6615#discussion_r255345766
 
 

 ##########
 File path: 
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/KeyedSerializationSchema.java
 ##########
 @@ -55,4 +57,13 @@
         * @return null or the target topic
         */
        String getTargetTopic(T element);
+
+       /**
+        *
+        * @param element The incoming element to be serialized
+        * @return collection of headers (maybe empty)
+        */
+       default Iterable<Map.Entry<String, byte[]>> headers(T element) {
 
 Review comment:
   What about `defaultTopic`? We need it, because 
`KeyedSerializationSchema.getTargetTopic` may (and I guess usually does) return 
null. We can add `defaultTopic` as parameter to 
`KafkaSerializationSchema.serialize` or we can add it to `PartitionInfo`. 
   
   And `int[] partitions` seems should be method `int[] 
PartitionInfo.partitions(String topicName), because 
`KeyedSerializationSchema.serialize` need ability to query partitions for 
arbitrary topic. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to