xueyumusic commented on a change in pull request #7576: 
[FLINK-11046][elasticsearch] Fix ElasticSearch6Connector thread blocked when 
index failed with retry
URL: https://github.com/apache/flink/pull/7576#discussion_r255373760
 
 

 ##########
 File path: 
flink-connectors/flink-connector-elasticsearch-base/src/test/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBaseTest.java
 ##########
 @@ -366,9 +366,9 @@ public void go() throws Exception {
 
                // since the previous flush should have resulted in a request 
re-add from the failure handler,
                // we should have flushed again, and eventually be blocked 
before snapshot triggers the 2nd flush
-               while (snapshotThread.getState() != Thread.State.WAITING) {
-                       Thread.sleep(10);
-               }
+//             while (snapshotThread.getState() != Thread.State.WAITING) {
+//                     Thread.sleep(10);
 
 Review comment:
   Thanks you very much for review and refactoring! @tzulitai , I will look 
deeply at this issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to