tillrohrmann commented on a change in pull request #7676: [FLINK-11364][tests]
Port TaskManagerFailsITCase to new code base
URL: https://github.com/apache/flink/pull/7676#discussion_r255875159
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/minicluster/TestingMiniCluster.java
##########
@@ -66,6 +67,17 @@ public TestingMiniCluster(TestingMiniClusterConfiguration
miniClusterConfigurati
return super.getDispatcherResourceManagerComponents();
}
+ @Nonnull
+ @Override
+ public CompletableFuture<Void> terminateTaskExecutor(int index) {
+ return super.terminateTaskExecutor(index);
+ }
+
+ @Override
+ public void startTaskExecutor(boolean localCommunication) throws
Exception {
Review comment:
Well, `MiniCluster` cannot know whether to use local communication or not at
start time, because `TestingMiniCluster` allows to start new `TaskExecutors`.
Thus, the only option would be to always set `localCommunication` to false in
the case of the `MiniCluster`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
