Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1066#issuecomment-135348048
Very good contribution. Thanks @akunft. The only thing would be to add a
test which verifies that the configuration is actually used for starting the
`JobClientActor's` `ActorSystem`, for example. We could set the framesize to
something so small that the job execution must fail. Or we change the default
parallelism as it is done in
`ExecutionEnvironmnetITCase.testLocalEnvironmentWithConfig`.
After adding the test, +1 for merging :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
