[
https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14716317#comment-14716317
]
ASF GitHub Bot commented on FLINK-2490:
---------------------------------------
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/992#issuecomment-135351424
While merging your pull request I noticed that the
`SocketTextStreamFunction` actually does not wait the time specified in
`CONNCTION_RETRY_SLEEP` but immediately tries to reconnect in case of an EOF.
It only waits in case of a `ConnectionError`. I'm not sure whether this
behavior is desired but this should also be reflected in your test cases. Could
you add a test case where you first pass a Socket with an EOF and then let an
`ConnectionError` occur?
> Remove unwanted boolean check in function
> SocketTextStreamFunction.streamFromSocket
> -----------------------------------------------------------------------------------
>
> Key: FLINK-2490
> URL: https://issues.apache.org/jira/browse/FLINK-2490
> Project: Flink
> Issue Type: Bug
> Components: Streaming
> Affects Versions: 0.10
> Reporter: Huang Wei
> Priority: Minor
> Fix For: 0.10
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
