zhijiangW opened a new pull request #7704: [FLINK-11604][network] Extend the necessary methods in ResultPartitionWriter interface URL: https://github.com/apache/flink/pull/7704 ## What is the purpose of the change *This is a preparation work for future creating `ResultPartitionWriter` via proposed `ShuffleService`.* *Currently there exists only one `ResultPartition` implementation for `ResultPartitionWriter` interface, so the specific `ResultPartition` instance is easily referenced in many other classes such as `Task`, `NetworkEnvironment`, etc. Even some private methods in `ResultPartition` would be called directly in these reference classes.* *Considering ShuffleService might create multiple different `ResultPartitionWriter` implementations future, then all the other classes should only reference with the interface and call the common methods. Therefore we extend the related methods in `ResultPartitionWriter` interface in order to cover existing logics in `ResultPartition`.* ## Brief change log - *Extend more methods in `ResultPartitionWriter` interface* - *Reference `ResultPartitionWriter` instead of `ResultPartition` in related classes* - *Introduce `TestResultPartitionWriter` for reusing and simplifying related tests* ## Verifying this change This change is already covered by existing tests, such as *RecordWriterTest*. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
