uce commented on a change in pull request #7668: [FLINK-11545] [container] Add
job-id arg to StandaloneJobClusterEntryPoint
URL: https://github.com/apache/flink/pull/7668#discussion_r256768221
##########
File path:
flink-container/src/main/java/org/apache/flink/container/entrypoint/StandaloneJobClusterConfiguration.java
##########
@@ -37,10 +40,14 @@
@Nonnull
private final SavepointRestoreSettings savepointRestoreSettings;
- public StandaloneJobClusterConfiguration(@Nonnull String configDir,
@Nonnull Properties dynamicProperties, @Nonnull String[] args, @Nullable String
hostname, int restPort, @Nonnull String jobClassName, @Nonnull
SavepointRestoreSettings savepointRestoreSettings) {
+ @Nonnull
+ private final JobID jobId;
+
+ StandaloneJobClusterConfiguration(@Nonnull String configDir, @Nonnull
Properties dynamicProperties, @Nonnull String[] args, @Nullable String
hostname, int restPort, @Nonnull String jobClassName, @Nonnull
SavepointRestoreSettings savepointRestoreSettings, @Nonnull JobID jobId) {
Review comment:
Sure/ What style do we follow here? One argument per line if we break the
line or just multiple lines with 120 characters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
