zentol commented on a change in pull request #7668: [FLINK-11545] [container]
Add job-id arg to StandaloneJobClusterEntryPoint
URL: https://github.com/apache/flink/pull/7668#discussion_r257158584
##########
File path:
flink-container/src/test/java/org/apache/flink/container/entrypoint/StandaloneJobClusterConfigurationParserFactoryTest.java
##########
@@ -97,4 +103,27 @@ public void testSavepointRestoreSettingsParsing() throws
FlinkParseException {
assertThat(savepointRestoreSettings.getRestorePath(),
is(equalTo(restorePath)));
assertThat(savepointRestoreSettings.allowNonRestoredState(),
is(true));
}
+
+ @Test
+ public void testSetJobIdManually() throws FlinkParseException {
+ final JobID jobId = new JobID();
+ final String[] args = {"--configDir", "/foo/bar",
"--job-classname", "foobar", "--job-id", jobId.toString()};
Review comment:
if `-jid` is an accepted command-line argument then I would consider it as
part of the API, in wbhicih case it should be covered by a test.
Is this just an artifact from the library we're using?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
