rmetzger commented on a change in pull request #6594: [FLINK-9311] [pubsub]
Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)
URL: https://github.com/apache/flink/pull/6594#discussion_r257166177
##########
File path: flink-examples/flink-examples-streaming/pom.xml
##########
@@ -562,6 +578,43 @@ under the License.
</filters>
</configuration>
</execution>
+ <!-- PubSub -->
+ <execution>
+ <id>PubSub</id>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+
<shadeTestJar>false</shadeTestJar>
+
<shadedArtifactAttached>true</shadedArtifactAttached>
+
<createDependencyReducedPom>false</createDependencyReducedPom>
+ <transformers>
+ <transformer
implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
+
<mainClass>org.apache.flink.streaming.examples.pubsub.PubSubExample</mainClass>
+ </transformer>
+ </transformers>
+
<finalName>PubSub</finalName>
+ <filters>
+ <filter>
+
<artifact>org.apache.flink:flink-connector-pubsub_${scala.binary.version}</artifact>
+
<includes>
+
<include>org/apache/flink/streaming/connectors/pubsub/**</include>
Review comment:
+1 on removing the `BoundedPubSubSource`
If we want a "bounding" functionality for sources, this should be
implemented in a more generic way
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
