StefanRRichter commented on issue #7586: [FLINK-10912][rocksdb] Configurable RocksDBStateBackend options URL: https://github.com/apache/flink/pull/7586#issuecomment-464732129 @Myasuka Thanks for your updates. I think overall the PR is almost complete, except for one case from our discussion that is not covered yet. With the PR, the user can configure the `ConfigurableOptionsFactory` with the flink-conf and the user can also set a completely different OptionsFactory in the code with `setOptions(...)`. However, the missing case is that the user is not yet able to configure a different `OptionsFactory` in the flink-conf, e.g. providing a class name that is then loaded. This would complete the set of configuration options. I have marked the part of the code where the change should be. After that, I think this looks good for merge!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
