aljoscha commented on a change in pull request #7734: [FLINK-11334][core]
Migrate EnumValueSerializer to use new serialization compatibility abstractions
URL: https://github.com/apache/flink/pull/7734#discussion_r257979490
##########
File path:
flink-scala/src/test/scala/org/apache/flink/api/scala/typeutils/EnumValueSerializerUpgradeTest.scala
##########
@@ -100,15 +100,15 @@ class EnumValueSerializerUpgradeTest extends TestLogger
with JUnitSuiteLike {
*/
@Test
def checkRemovedField(): Unit = {
- assertTrue(checkCompatibility(enumA, enumC).isIncompatible)
+ assertTrue(checkCompatibility(enumA, enumC).isCompatibleAfterMigration)
}
/**
* Check that changing the enum field order requires migration
*/
@Test
def checkDifferentFieldOrder(): Unit = {
- assertTrue(checkCompatibility(enumA, enumD).isIncompatible)
+ assertTrue(checkCompatibility(enumA, enumD).isCompatibleAfterMigration)
Review comment:
As mentioned above, this should probably be incompatible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
