yuqi1129 commented on a change in pull request #7729: [FLINK-11643] remove
useless code of externalizedCheckpointsDir
URL: https://github.com/apache/flink/pull/7729#discussion_r257999837
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/StateBackendLoader.java
##########
@@ -104,22 +104,23 @@ public static StateBackend loadStateBackendFromConfig(
// by default the factory class is the backend name
String factoryClassName = backendName;
+ final boolean logIsNotNull = logger != null;
switch (backendName.toLowerCase()) {
case MEMORY_STATE_BACKEND_NAME:
MemoryStateBackend memBackend = new
MemoryStateBackendFactory().createFromConfig(config);
- if (logger != null) {
+ if (logIsNotNull) {
Review comment:
I just think `logIsNotNull` is more readable as there are many `logger !=
null` logic in the method. Ok, i will revert this point if it make no sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
