StefanRRichter commented on a change in pull request #7586: 
[FLINK-10912][rocksdb] Configurable RocksDBStateBackend options
URL: https://github.com/apache/flink/pull/7586#discussion_r258020951
 
 

 ##########
 File path: 
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackend.java
 ##########
 @@ -454,9 +460,21 @@ public CheckpointStorage createCheckpointStorage(JobID 
jobId) throws IOException
                LocalRecoveryConfig localRecoveryConfig =
                        env.getTaskStateManager().createLocalRecoveryConfig();
 
+               ClassLoader userClassLoader = env.getUserClassLoader();
+
+               if (optionsFactory instanceof UserConfiguredOptionsFactory) {
 
 Review comment:
   If we would `Class.forName(...)` in the `backend.configure(...)`, this would 
not be required.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to