igalshilman commented on a change in pull request #7759:
[FLINK-11485][FLINK-10897] POJO state schema evolution / migrate PojoSerializer
to use new compatibility APIs
URL: https://github.com/apache/flink/pull/7759#discussion_r258449047
##########
File path:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializer.java
##########
@@ -144,13 +145,14 @@ public PojoSerializer(
this.subclassSerializerCache = new HashMap<>();
}
- public PojoSerializer(
+ PojoSerializer(
Class<T> clazz,
Field[] fields,
TypeSerializer<Object>[] fieldSerializers,
LinkedHashMap<Class<?>, Integer> registeredClasses,
TypeSerializer<?>[] registeredSerializers,
- HashMap<Class<?>, TypeSerializer<?>>
subclassSerializerCache) {
+ HashMap<Class<?>, TypeSerializer<?>>
subclassSerializerCache,
Review comment:
Can that be a `Map` instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
