tzulitai commented on a change in pull request #7765: [FLINK-11334][core]
Migrate enum serializers to use new serialization compatibility abstractions
URL: https://github.com/apache/flink/pull/7765#discussion_r258483641
##########
File path:
flink-core/src/test/java/org/apache/flink/api/common/typeutils/TypeSerializerSnapshotMigrationTestBase.java
##########
@@ -452,11 +490,12 @@ protected boolean
matchesSafely(TypeSerializerSchemaCompatibility<T> testResultC
if (expectedCompatibilty.isCompatibleAsIs()) {
return
testResultCompatibility.isCompatibleAsIs();
} else if
(expectedCompatibilty.isIncompatible()) {
- return
testResultCompatibility.isCompatibleAfterMigration();
- } else if
(expectedCompatibilty.isIncompatible()) {
- return
testResultCompatibility.isIncompatible();
+ return
testResultCompatibility.isCompatibleAfterMigration() ||
+
testResultCompatibility.isIncompatible();
Review comment:
looks a bit odd.
I think it's supposed to be
```
...
} else if (expectedCompatibilty.isIncompatible()) {
return testResultCompatibility.isIncompatible();
} else if (expectedCompatibilty.isCompatibleAfterMigration()) {
return testResultCompatibility.isCompatibleAfterMigration();
}
...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
