dawidwys commented on a change in pull request #7777: [FLINK-9964][table] Add
a full RFC-compliant CSV table format factory
URL: https://github.com/apache/flink/pull/7777#discussion_r258944767
##########
File path:
flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/CsvRowSerializationSchema.java
##########
@@ -240,19 +260,23 @@ private JsonNode convert(ContainerNode<?> container,
Object obj, TypeInformation
}
}
- private ArrayNode convertRow(Row row, RowTypeInfo rowTypeInfo) {
+ private ArrayNode convertNestedRow(Row row, RowTypeInfo rowTypeInfo) {
final ArrayNode arrayNode = csvMapper.createArrayNode();
final TypeInformation[] types = rowTypeInfo.getFieldTypes();
+ if (row.getArity() != types.length) {
Review comment:
Extract to helper method? The same block is used twice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
