carp84 commented on a change in pull request #7674: [FLINK-10043] [State Backends] Refactor RocksDBKeyedStateBackend object construction/initialization/restore code URL: https://github.com/apache/flink/pull/7674#discussion_r259023397
########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/state/ttl/StateBackendTestContext.java ########## @@ -34,6 +34,7 @@ import org.apache.flink.runtime.state.SnapshotResult; import org.apache.flink.runtime.state.StateBackend; import org.apache.flink.runtime.state.internal.InternalKvState; +import org.apache.flink.shaded.guava18.com.google.common.collect.Lists; Review comment: Here we need to create a collection with a single element. I've tried `Collections.singletonList` and `Arrays.asList` but neither is ok since we will call `remove` method of this collection later. So we will need to write more codes by ourselves to get rid of this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
