carp84 commented on issue #7674: [FLINK-10043] [State Backends] Refactor RocksDBKeyedStateBackend object construction/initialization/restore code URL: https://github.com/apache/flink/pull/7674#issuecomment-466303453 To convenient the review on compact filter registering part, let me clarify the current process after refactoring: - Incremental restore - restore with rescaling - init db from a certain sst: `createAndRegisterColumnFamilyDescriptors` when prepare files, before db open - data ingestion after db open: `getOrRegisterStateColumnFamilyHandle` before creating column family - restore without rescaling: `createAndRegisterColumnFamilyDescriptors` when prepare files, before db open - Full restore - data ingestion after db open: `getOrRegisterStateColumnFamilyHandle` before creating column family
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
